fix: preserve Gemini thinking blocks#5713
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
he-yufeng
force-pushed
the
fix/gemini-thinking-block-signatures
branch
from
bee917c to
51542ce
Compare
Author
|
Rebased this onto current upstream/main and force-pushed the branch. The PR diff is still limited to the LiteLLM Gemini thinking-block handling and its unit coverage. Local validation after the rebase:
The remaining visible failure is still the repository triage bot, not a code test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thinking_blockseven when blocks do not carry Anthropic-style per-block signaturesprovider_specific_fields.thought_signaturesinto those blocks before converting them to ADK thought partsFixes #5712.
To verify
python -m pytest tests/unittests/models/test_litellm.py -q -k "thinking_blocks or thought_signature" --basetemp .tmp/pytestpython -m pytest tests/unittests/models/test_litellm.py -q --basetemp .tmp/pytestpython -m py_compile src/google/adk/models/lite_llm.py tests/unittests/models/test_litellm.pypython -m pyink --check src/google/adk/models/lite_llm.py tests/unittests/models/test_litellm.py